[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Strange code in xterm.c

From: Jan Djärv
Subject: Re: Strange code in xterm.c
Date: Mon, 20 Dec 2010 20:58:28 +0100
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; sv-SE; rv: Gecko/20101129 Thunderbird/3.1.7

It seems I cut away too much when I removed some of the fullscreen stuff. This code looks non-functional, it also doesn't resize the frame. As this code only gets run when there is no window manager present, nobody noticed.
I'll clean it up in a day or three.

        Jan D.

Eli Zaretskii skrev 2010-12-20 11.45:
This a large part of the body of x_check_fullscreen:

       int width = FRAME_COLS (f), height = FRAME_LINES (f);
       struct x_display_info *dpyinfo = FRAME_X_DISPLAY_INFO (f);

       switch (f->want_fullscreen)
           /* No difference between these two when there is no WM */
         case FULLSCREEN_BOTH:
           width = x_display_pixel_width (dpyinfo);
           height = x_display_pixel_height (dpyinfo);
         case FULLSCREEN_WIDTH:
           width = x_display_pixel_width (dpyinfo);
         case FULLSCREEN_HEIGHT:
           height = x_display_pixel_height (dpyinfo);

       if (FRAME_COLS (f) != width || FRAME_LINES (f) != height)
           change_frame_size (f, height, width, 0, 1, 0);
           SET_FRAME_GARBAGED (f);
           cancel_mouse_face (f);

Am I missing something, or does it mix up display dimensions in pixels
and in character units?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]