[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch for fields of `struct buffer'

From: Tom Tromey
Subject: Re: Patch for fields of `struct buffer'
Date: Fri, 28 Jan 2011 10:38:18 -0700
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)

Stefan> Please make the "#define BUF_FOO(BUF) ((BUF)->foo_)" to be
Stefan> auto-generated (they could go into global.h).

Ok, I will look at this.
I think it will mean first making the current global.h be generated.
At least, that will make it simpler.

Stefan> Oh and the arg shojuld be `buf' rather than `BUF'.

Stefan> I'd also be happier if the buffer.h code that defines the fields
Stefan> used names without _ (so they'd have to be passed to a macro
Stefan> that adds the _).  Similarly the alloc.c code should ideally not
Stefan> hard-code the "add an _" at every use but instead use some kind
Stefan> of macro call like BUFFER_INTERNAL_FIELD(foo) that would return
Stefan> "foo_".

I implemented all these things.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]