[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] delete-trailing-whitespace on active region

From: Stefan Monnier
Subject: Re: [PATCH] delete-trailing-whitespace on active region
Date: Wed, 09 Feb 2011 21:35:29 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> +  (interactive "*r")

Using "r" and then checking region-active-p sounds clever, but is wrong:
- "r" will fail if the mark has never been set in the current buffer.
- checking region-active-p is wrong in non-interactive use.
I.e. the `interactive' spec should do the region-active-p check.
Oh, and it should use use-region-p instead of region-active-p.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]