[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch make configure.bat support --cflags and --ldflags options that

From: Ben Key
Subject: Re: Patch make configure.bat support --cflags and --ldflags options that include quotes
Date: Fri, 29 Apr 2011 10:11:47 -0500

Eli Zaretskii wrote:

> Maybe I'm missing something, but where is the fallback, exactly?

The code that you refrenced is simply not called in the fallback case, due to the following code

if "%use_extensions%" == "1" goto ucflagex
goto ucflagne

The code you referred to is in the ucflagex case, but, if command extensions are not enabled, the ucflagne case is used.  In the ucflagne case there are the following lines.

set usercflags=%usercflags%%sep1%%1
set fusercflags=%usercflags%

The first of these lines sets usercflags without attempting to use the command extensions magic that strips quotes and thus providing support for options in the form of -DFOO=BAR as long as they are enclosed in quotes and the second line sets fusercflags so that it simply contains the value of usercflags

The line
latter in the file that you referred to,
if (%docflags%) == (Y) echo #define USER_CFLAGS " %fusercflags%">>config.tmp
, uses only the fusercflags variable which is fine.  This is because of the fact that, even if command extensions are not enabled, the fusercflags variable will be set to the appropriate value.  The
fusercflags variable will have the same value as the usercflags variable if command extensions are not available and will be equal to the usercflags variable with all the quotes escaped by the backslash character if command extensions are available.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]