[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GnuTLS support on Woe32

From: Eli Zaretskii
Subject: Re: [PATCH] GnuTLS support on Woe32
Date: Tue, 03 May 2011 19:47:11 +0300

> From: Juanma Barranquero <address@hidden>
> Date: Tue, 3 May 2011 12:01:17 +0200
> Cc: address@hidden, address@hidden
> On Tue, May 3, 2011 at 06:19, Eli Zaretskii <address@hidden> wrote:
> > However, this:
> >
> >> +#include "lisp.h"
> >
> > is bad: lisp.h is already included in too many places.  Why did you
> > need this?
> Because of Lisp_Object. The alternative would be to put Vlibrary_cache
> and w32_delayed_load in another module.

?? But we have gobs of other headers that use Lisp_Object, and none of
them includes lisp.h.  We simply should be careful to include lisp.h
before everything else, including w32.h.  Doesn't that work for you?

> >  . it should describe the structure of the LIBRARIES alist explicitly,
> >   like you'd do in a doc string, not just refer to
> >   `dynamic-library-alist'
> >
> >  . it says nothing about the second argument (and IIUC what it means,
> >   the "_id" part of the variable name is misleading)
> IIRC, I just moved the code from image.c to here and renamed the
> variables.

Yes, I know.  I thought it was good to clean it up a bit while you are
at that.  But if you want to leave fixing this to another rainy day, I
will understand.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]