[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] GnuTLS support on Woe32

From: Ted Zlatanov
Subject: Re: [PATCH] GnuTLS support on Woe32
Date: Tue, 03 May 2011 20:56:35 -0500
User-agent: Gnus/5.110016 (No Gnus v0.16) Emacs/24.0.50 (gnu/linux)

On Wed, 4 May 2011 03:30:23 +0200 Juanma Barranquero <address@hidden> wrote: 

JB> 2011/5/3 Ted Zlatanov <address@hidden>:
>> The else block above should log things at level 1, I think, since it's a
>> rare event and important to know:
>> CHECK_STRING (Qgnutls_dll);
>> GNUTLS_LOG2 (1, max_log_level, "loading the GnuTLS DLL: ", SSDATA 
>> (Qgnutls_dll));

JB> Qgnutls_dll is not really the file name, but just the symbol `gnutls'.
JB> The file name is not known outside of w32_delayed_load, so it can't
JB> really be used in the message.

Could you push it into the :dll property of that symbol (always a list)?
Then just loop on all the names when logging later.

JB> I thought of adding GNUTLS_LOG (1, max_log_level, "..."), but isn't
JB> GnuTLS required to be able to compute max_log_level? If so, it can
JB> only be used to log a successful load, and then its place is really in
JB> Fgnutls_boot, not Fgnutls_available_p.

You could just say GNUTLS_LOG2 (1, 1, "loading the GnuTLS DLL: ",
filename) so it's unconditional (not the end of the world) or use the
int value of `gnutls-log-level' directly from gnutls.el...  Either way
is fine with me, but logging the file name is IMO important if possible.
If not just use GNUTLS_LOG as you say.

JB> Attached is the new patch, which is like the previous one, with the
JB> changes requested by Eli and a clarification in nt/INSTALL. I think it
JB> is ready to install once we settle on the issue of GNUTLS_LOG.

Thanks so much!


reply via email to

[Prev in Thread] Current Thread [Next in Thread]