[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 5x5 again

From: Stefan Monnier
Subject: Re: 5x5 again
Date: Tue, 24 May 2011 15:23:59 -0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux)

> Here follows the Changelog and the patch. Sorry for the extra
> disturbance.

Installed, with the following nitpicks:

>       * play/5x5.el (5x5-new-game, 5x5-randomize): reset
>       5x5-solver-output to nil when a new grid is cast.

"reset" needs to be capitalized.

>       (5x5-log-init, 5x5-log): use defsubst instead of defmacro to shunt

"use" needs to be capitalized.

>       these debugging traces, as defmacro breaks the compiled code. Note

Two spaces after ".".

>       these logging facilities were not cleaned out as the aritmetic
>       solver is not yet complete --- it works only for grid size = 5. So
>       they may be useful again to design a more generic solution.

I moved this into the code, where it belongs.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]