Re: [PATCH updated] Support for filesystem watching (inotify)

[Stefan Monnier]

Thanks for your review, I generally agree with your comments.

> Moreover, you need to decide what to do given, for example:
>  (progn (file-watch "foo" 'modify 'notify-modify)
>         (file-watch "foo" 'move 'notify-move))
> Is this OK, is this an error, is this "close to" an error?

I think dired shouldn't need to know if some other package decided to
watch the same directory, so having several watchers for the same file
should be accepted and work correctly, i.e. both callbacks should be run
when needed.

> I think a simple "file is already in" check is insufficient.
>    +  watch_list = Fcons(Fcons(make_number(watchdesc), Flist(2, args)), 
> watch_list);
> You can use ‘acons’: (acons K V ALIST) ≡ (cons (cons K V) ALIST).

No, Fcons is the right thing to use there.
We could #define ACONS(a,b,c) Fcons(Fcons(a,b),c)
but that's orthogonal to this patch.


        Stefan