[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mar
From: |
Eli Zaretskii |
Subject: |
Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs. |
Date: |
Thu, 11 Aug 2011 00:48:39 -0400 |
> Date: Thu, 11 Aug 2011 06:02:39 +0300
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden, address@hidden
>
> > From: Stefan Monnier <address@hidden>
> > Date: Wed, 10 Aug 2011 22:14:28 -0400
> > Cc: address@hidden
> >
> > > +** New function `string-mark-left-to-right' appends a Unicode LRM
> > > +(left-to-right mark) character to a string if it terminates in
> > > +right-to-left script.
>
> This algorithm (which the code implements) is wrong: the unwanted
> reordering can happen even if the string does not end in a strong R
> character. It could end in a series of weak characters, if the strong
> character preceding that is R, for example.
And since buffer-menu.el was already modified to use this function, it
is easy to see how this algorithm fails: make a buffer whose name is
made of all R2L characters with the "<1>" tail appended, then type
"C-x C-b" and watch the messed-up display. The original code treated
this case correctly.
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Stefan Monnier, 2011/08/10
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Eli Zaretskii, 2011/08/10
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs.,
Eli Zaretskii <=
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Chong Yidong, 2011/08/11
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Eli Zaretskii, 2011/08/12
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Chong Yidong, 2011/08/12
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Eli Zaretskii, 2011/08/12
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Chong Yidong, 2011/08/12
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Eli Zaretskii, 2011/08/12
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Kenichi Handa, 2011/08/13
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Eli Zaretskii, 2011/08/13
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Kenichi Handa, 2011/08/13
- Re: [Emacs-diffs] /srv/bzr/emacs/trunk r105429: New function `string-mark-left-to-right' for handling LRMs., Stefan Monnier, 2011/08/13