[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A few Windows build fixes

From: Eli Zaretskii
Subject: Re: A few Windows build fixes
Date: Mon, 29 Aug 2011 02:15:53 -0400

> From: Hannu Koivisto <address@hidden>
> Date: Mon, 29 Aug 2011 01:46:59 +0300
> I wanted to build the latest bzr trunk version of Emacs for Windows
> but soon realized that the makefiles and the configure process have
> lots of problems.

Only if you use Cygwin tools.  With native (MinGW/GnuWin32) tools,
there are no known problems, AFAIK.

> I'm attaching four patches that fix enough of the problems that
> building and installing with a modern Cygwin


> +if %MAKECMD% == gmake dos2unix config.tmp config.settings

This requires users to have dos2unix installed, even if they don't use
the Cygwin tools to build Emacs.  If there's another way of doing this
that doesn't require another non-standard utility (e.g., by setting
some Cygwin-specific environment variable that is ignored by
non-Cygwin programs), or else some alternative condition that will
only fire with Cygwin Make being used, please modify this to use
that.  Otherwise, some other trick will be needed to avoid the extra
requirement of having dos2unix on PATH.

> --- a/nt/makefile.w32-in
> +++ b/nt/makefile.w32-in

Is there some real change here, or did you only change EOL format?  If
the former, please show just the changes in content.

> Cygwin make doesn't like c:/foo/bar style paths at least in targets and
> native Windows Emacs doesn't like Cygwin style /cygdrive/c/foo/bar paths.
> Use relative paths to avoid the problem.

It's true that the Cygwin build of Make doesn't support c:/foo in
targets, but the Windows Makefiles never use such targets, except
through $(CURDIR), which should return a Cygwin style file name with
Cygwin Make.  So I don't really see a problem that needs to be solved
here.  Perhaps I'm missing something; please show the actual problems
you had with this part.

In any case, I'd like to find a solution for this problem that targets
Cygwin alone, if possible.  Sprinkling quotes in 2 different styles
all over the Makefiles is not my idea of fun, because the quoting
issue is very fragile on Windows to begin with, especially since we
try to support at least 3 or 4 different combinations of tools.


This will break "make -C", won't it?  Or at least make it fragile and

> -     - mkdir "$(INSTALLDIR)"
> +     - mkdir -p "$(INSTALLDIR)"

Please don't.  We don't want to rely on the assumption that `mkdir' is
a GNU mkdir.exe.  This command needs also to run when the shell is
cmd.exe, and its built-in `mkdir' doesn't support the -p switch (it
creates intermediate directories by default).

There are more places where you use "mkdir -p"; please find some other
solution for that particular problem, or let's leave it unsolved, as
no one has complained until now, AFAIR.

> +ifeq "$(shell cygpath $(INSTALL_DIR))" "$(INSTALL_DIR)"
> +INSTALL_DIR_MIXED := $(shell cygpath -m "$(INSTALL_DIR)")
> +endif

I don't understand the need for this gork.  Please explain.  Is the
Cygwin build supposed to use Cygwin `cp' etc., or their native

In any case, why do we need both INSTALL_DIR and INSTALL_DIR_MIXED?

If both are needed, we will need a corresponding change in nmake.defs.

Thanks again for working on this.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]