[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] minibuffer issue with eshell-command
From: |
Stefan Monnier |
Subject: |
Re: [PATCH] minibuffer issue with eshell-command |
Date: |
Thu, 06 Oct 2011 11:36:33 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) |
>> When eshell-command start, it set eshell-mode in all minibuffers:
>> ;(add-hook 'minibuffer-setup-hook 'eshell-mode)
>> So when running another minibuffer, while eshell-command is started,
>> it enable eshell-mode in this one, which is wrong.
>> This patch fix this:
> Any objections to push this on trunk?
That looks OK, except that I think the add-hooks should be moved to the
setup-hook function where they can be made to only apply locally (and
I guess at that point you can get rid of the remove-hooks).
Stefan