Re: valgrind warnings [Re: Emacs bzr memory footprint]

[Dan Nicolaescu]

Dan Nicolaescu <address@hidden> writes:


> valgrind ./temacs
>
> Valgrind produces these warnings, maybe some of them are interesting:
>
> ==30382== Conditional jump or move depends on uninitialised value(s)
> ==30382==    at 0x4731E6: note_mouse_highlight (xdisp.c:26841)
> ==30382==    by 0x4F8682: note_mouse_movement (xterm.c:3830)
> ==30382==    by 0x4FCB2E: handle_one_xevent (xterm.c:6652)
> ==30382==    by 0x4FD792: XTread_socket (xterm.c:7133)
> ==30382==    by 0x5437F7: read_avail_input (keyboard.c:6821)
> ==30382==    by 0x54409F: handle_async_input (keyboard.c:7149)
> ==30382==    by 0x5440BE: process_pending_signals (keyboard.c:7165)
> ==30382==    by 0x62D713: wait_reading_process_output (process.c:4340)
> ==30382==    by 0x419ED2: sit_for (dispnew.c:5971)
> ==30382==    by 0x53AF87: read_char (keyboard.c:2687)
> ==30382==    by 0x548876: read_key_sequence (keyboard.c:9290)
> ==30382==    by 0x538709: command_loop_1 (keyboard.c:1447)

This is because window_from_coordinates in note_mouse_highlight is
passed "&part", where "part" is an uninitialized local variable.
When !NILP(window) "part" is not touched, so it stays uninitialized.
Can someone who understands this code fix this please?

> ==30382== Conditional jump or move depends on uninitialised value(s)
> ==30382==    at 0x46D785: x_write_glyphs (xdisp.c:24661)
> ==30382==    by 0x413E4A: update_text_area (dispnew.c:3765)
> ==30382==    by 0x414794: update_window_line (dispnew.c:4006)
> ==30382==    by 0x413A1A: update_window (dispnew.c:3625)
> ==30382==    by 0x413256: update_single_window (dispnew.c:3370)
> ==30382==    by 0x511A93: Fx_show_tip (xfns.c:5189)
> ==30382==    by 0x5D6E47: Ffuncall (eval.c:2995)
> ==30382==    by 0x622C5B: exec_byte_code (bytecode.c:785)
> ==30382==    by 0x6221C6: Fbyte_code (bytecode.c:423)
> ==30382==    by 0x5D56AB: eval_sub (eval.c:2328)
> ==30382==    by 0x5D381A: internal_lisp_condition_case (eval.c:1453)
> ==30382==    by 0x62392A: exec_byte_code (bytecode.c:981)

I think I fixed this one.