[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] add "underwave" face attribute

From: Aurélien Aptel
Subject: Re: [patch] add "underwave" face attribute
Date: Sat, 4 Feb 2012 19:22:42 +0100

On Sat, Feb 4, 2012 at 9:14 AM, Jan Djärv <address@hidden> wrote:
> Just create a new GC.

That's what I ended up doing, but the previous GC already sets a
clipping region that I override when underwaving. This results in
unneeded underwaving ie. visual glitches.

I've looked deeply at the code and found a function that returns a
simple clip rectangle of a glyph_string and used it with
x_intersect_rectangles() to have the final clipping region. I then use
the clip field of glyph_string to restore the previous clipping

I've done the same thing for Windows, it should work. Juanma, could
you check again, please?
Mac OSX clipping works differently and I'm not sure what to do... See
XXX coments in nsterm.m

Patch attached.

Attachment: underwave-clip-1.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]