Re: [Emacs-diffs] /srv/bzr/emacs/trunk r107377: * src/lisp.h: Improve comment about USE_LSB_TAG.

[Stefan Monnier]

>> What I suggest is just to take the O(N) pointer-sized entities on
>> the stack, cast them to EMACS_INT, and pass them to
>> mark_maybe_object.
> Thanks, I see now.  Something like the following, then.
> Yes, that does simplify things.

Your patch doesn't look bad, but is too intrusive for 24.1.
I think for 24.1 we can install one that just does:

>    for (pp = start; (void *) pp < end; pp++)
>      for (i = 0; i < sizeof *pp; i += GC_POINTER_ALIGNMENT)
> -      mark_maybe_pointer (*(void **) ((char *) pp + i));
> +      {
> +     void *p = *(void **) ((char *) pp + i);
> +     mark_maybe_pointer (p);
> + #ifdef WIDE_EMACS_INT
> +       mark_maybe_object (widen_to_Lisp_Object (p));
> + #endif
> +      }
>  }

With an appropriate comment (mostly moved from the USE_LSB_TAG comment
which can be trimmed down since the avoidance of USE_LSB_TAG on
WIDE_EMACS_INT is not performed for correctness reasons any more).


        Stefan