[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Windows 64 port

From: Fabrice Popineau
Subject: Re: Windows 64 port
Date: Thu, 22 Mar 2012 18:15:17 +0100

2012/3/1 Paul Eggert <address@hidden>
> - const problems in regex.c (large patch, but harmless)

None of the regex.c changes are needed for Windows 64.  The code works
fine without it and the patch does not fix any bugs.  Perhaps regex.c
should be made cleaner, const-wise, but that's an independent issue
and if we want to make that change it be as part of an independent patch.

Actually, it is much simpler than my previous attempt.
MSVC supports const, and so does GCC. So, define unconditionaly 
're_char' to be 'const unsigned char' and avoid the double 'const' 
because of 'const re_char' in various places (why those few const anyway,
given that with gcc, every re_char is already const ?).


Attachment: regex.c.diff
Description: Binary data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]