[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Proposal: 'struct window' cleanup
From: |
Stefan Monnier |
Subject: |
Re: Proposal: 'struct window' cleanup |
Date: |
Wed, 23 May 2012 10:23:14 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) |
> === modified file 'src/ChangeLog'
> --- src/ChangeLog 2012-05-22 18:31:19 +0000
> +++ src/ChangeLog 2012-05-23 04:38:27 +0000
> @@ -1,3 +1,38 @@
> +2012-05-23 Dmitry Antipov <address@hidden>
> +
> + For a 'struct window', replace some Lisp_Object fields to
> + bitfields where appropriate, remove unused fields.
> + * window.h (struct window): remove unused 'last_mark_x' and
> + 'last_mark_y' fields.
> + * window.h (struct window): rename 'mini_p' field to 'mini',
> + change it's type from Lisp_Object to bitfield.
> + * window.h (struct window): change type of 'force_start',
> + 'optional_new_start', 'last_had_star', 'update_mode_line'
> + and 'start_at_line_beg' fields from Lisp_Object to bitfield.
Please capitalize your sentences. And you can merge those three:
For a 'struct window', replace some Lisp_Object fields to
bitfields where appropriate, remove unused fields.
* window.h (struct window): Remove unused 'last_mark_x' and
'last_mark_y' fields. Rename 'mini_p' field to 'mini',
change it's type from Lisp_Object to bitfield.
Change type of 'force_start', 'optional_new_start',
'last_had_star', 'update_mode_line' and 'start_at_line_beg'
fields from Lisp_Object to bitfield.
> + * fileio.c (Finsert_file_contents): adjusted for a new
> + type of 'start_at_line_beg'.
> + * frame.c (make_frame, make_minibuffer_frame): adjusted for
> + a new type of 'mini'.
> + * keyboard.c (command_loop_1): adjusted for a new type
> + of 'force_start'.
> + * window.c (Fset_window_start, window_loop)
> + (Fdelete_other_windows_internal, set_window_buffer)
> + (Fforce_window_update, make_window, window_scroll_pixel_based)
> + (window_scroll_line_based, Frecenter, Fmove_to_window_line)
> + (Fset_window_configuration, save_window_save): adjusted for
> + a type changes in 'struct window'.
> + * xdisp.c (update_menu_bar, update_tool_bar): adjusted for
> + a new type of 'last_had_star' and 'update_mode_line'.
> + * xdisp.c (redisplay_internal): adjusted for a new type
> + of 'update_mode_line', 'force_start' and 'optional_new_start'.
> + * xdisp.c (mark_window_display_accurate_1): adjusted for
> + a new type of 'last_had_star' and 'update_mode_line'.
> + * xdisp.c (redisplay_window): adjusted for
> + a type changes in 'struct window'.
> + * xdisp.c (try_window): adjusted for a new type of 'update_mode_line'.
> + * xfns.c (x_set_menu_bar_lines): adjusted for a new type
> + of 'update_mode_line'.
All these can be summarized by "Adjust users accordingly" in the
"* window.h (struct window):" entry.
The rest of the patch looks ready for installation. IOW, please install
it, and thank you,
Stefan