[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 'struct window' cleanup #3

From: Dmitry Antipov
Subject: Re: 'struct window' cleanup #3
Date: Wed, 27 Jun 2012 21:59:58 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1

On 06/27/2012 09:24 PM, Eli Zaretskii wrote:
Date: Wed, 27 Jun 2012 11:10:34 +0400
From: Dmitry Antipov <address@hidden>
CC: address@hidden

1. IIUC, `window_initialized' is redundant and obsolete.

Does it still work to run "./temacs -Q", after this change:

-  if (window_initialized)
+  if (initialized)

The reason I ask is because window_initialized was set non-zero in
init_window_once, which was called from emacs.c when 'initialized' is
zero.  So the above 'if' would trigger when 'initialized' was zero,
but after your change it will only trigger when 'initialized' is
non-zero.  Am I missing something?  'initialized' is zero when running
un-dumped Emacs, e.g. 'temacs'.

I would like to propose alternate redesign for this: init_window_once
sets Vframe_list to Qnil. After calling make_initial_frame, Vframe_list
becomes non-nil, so !NILP (Vframe_list) means init_window_once was


Attachment: window_init.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]