[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: commit 108757 breaks clang build on so x

From: John Wiegley
Subject: Re: commit 108757 breaks clang build on so x
Date: Fri, 29 Jun 2012 17:20:13 -0500
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin)

>>>>> Kai Tetzlaff <address@hidden> writes:

> It seems that

>   __attribute__((no_address_safety_analysis))

> is not supported by all clang versions. The attached patch contains an
> improved version of the check which hopefully fixes the problem (it does so
> here).

Thanks for catching that, Kai.  I forgot that the address sanitizer was only
introduced in 3.1.

FYI- The sanitizer only works up to the temacs build.  The dumped Emacs that
results will not work because static construction/destruction fails in the
ASan libraries.  Until I can build Clang with shared ASan libraries (I've
entered a bug against this in their bugtracker), running a fully sanitized
Emacs is still a pipe dream.

It has already found one legitimate stack overwrite in charset.c.  I'm still
testing the fix.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]