[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Windows build broken on trunk

From: Dmitry Antipov
Subject: Re: Windows build broken on trunk
Date: Wed, 18 Jul 2012 13:55:59 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1

On 07/18/2012 12:42 PM, Andy Moreton wrote:

Bootstrapping trunk on Windows (mingw32 GCC 4.6.1) failed this morning:

w32font.c:78:40: error: static declaration of 'Qsymbol' follows non-static 
lisp.h:2335:41: note: previous declaration of 'Qsymbol' was here
mingw32-make[3]: *** [oo/i386/w32font.o] Error 1
mingw32-make[3]: Leaving directory `C:/emacs/src/emacs/trunk/src'

This appers to be from r109131 committed by Dmitry Antipov.

I'm not familiar with the code: is the static Qsymbol used in w32font.c
referring to some aspect of font handling, or is it the same thing as the
global that was added to src/lisp.h ?

IIUC it's font handling stuff, and (IMHO) it should be renamed from too
generic name to something which is closely related to symbol's real use.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]