[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[patch] bug-reference.el

From: Arne Jørgensen
Subject: [patch] bug-reference.el
Date: Thu, 19 Jul 2012 14:14:38 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1 (darwin)


I think bug-reference.el is missing a "(provide 'bug-reference)".

And I would suggest changing `bug-reference-bug-regexp' from a constant
to a variable and marking it as safe-local-variable for
`string-or-null-p'. This way it is possible to bind it in .dir-locals.el
like it is already possible to bind `bug-reference-url-format'.

Kind regards,

--- bug-reference.el-OLD        2012-07-19 14:09:15.000000000 +0200
+++ bug-reference.el    2012-07-19 14:07:17.000000000 +0200
@@ -61,10 +61,13 @@
            (and (symbolp s)
                 (get s 'bug-reference-url-format)))))
-(defconst bug-reference-bug-regexp
+(defvar bug-reference-bug-regexp
   "\\([Bb]ug ?#\\|[Pp]atch ?#\\|RFE ?#\\|PR 
   "Regular expression which matches bug references.")
+(put 'bug-reference-bug-regexp 'safe-local-variable 'string-or-null-p)
 (defun bug-reference-set-overlay-properties ()
   "Set properties of bug reference overlays."
   (put 'bug-reference 'evaporate t)
@@ -154,4 +157,6 @@
       (bug-reference-unfontify (point-min) (point-max)))))
+(provide 'bug-reference)
 ;;; bug-reference.el ends here

reply via email to

[Prev in Thread] Current Thread [Next in Thread]