Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109223: Utility function to make a list from specified amount of objects.

[Eli Zaretskii]

> Date: Fri, 27 Jul 2012 13:17:00 +0400
> From: Dmitry Antipov <address@hidden>
> Cc: address@hidden, Emacs development discussions <address@hidden>
> 
> On 07/27/2012 12:21 PM, martin rudalics wrote:
> 
> >> Two obvious typos are fixed in 109225.
> >
> > I already fixed those here but am still getting:
> >
> > w32fns.c: In function 'syms_of_w32fns':
> > w32fns.c:6797:13: error: expected expression before ',' token
> > make[1]: *** [oo/i386/w32fns.o] Error 1
> > make[1]: Leaving directory `c:/emacs/trunk/src'
> > make: *** [all-other-dirs-gmake] Error 2
> 
> Hm... name clash? Can you preprocess and see what PURE is expanded to?

It is expanded to an empty string:

  Fput (Qundefined_color, Qerror_conditions,
 listn (, 2, Qundefined_color, Qerror));

This is because:

  # 69 "D:/usr/bin/../lib/gcc/mingw32/3.4.2/../../../../include/basetyps.h" 3
  #define STDMETHOD(m) HRESULT(STDMETHODCALLTYPE *m)
  #define STDMETHOD_(t,m) t(STDMETHODCALLTYPE *m)
  #define PURE 
  #define THIS_ INTERFACE *,
  #define THIS INTERFACE *

But note that gmalloc.c also has its own definition for HEAP:

  /* Determine the amount of memory spanned by the initial heap table
     (not an absolute limit).  */
  #define HEAP          (INT_BIT > 16 ? 4194304 : 65536)

Morale: never use too general names for symbols.

I fixed this by renaming the constants to CONSTYPE_PURE and
CONSTYPE_HEAP.