[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/9] Implement cygw32

From: Stefan Monnier
Subject: Re: [PATCH 3/9] Implement cygw32
Date: Tue, 07 Aug 2012 11:40:36 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

> +    AC_MSG_ERROR([Using win32 with an autotools build is only supported for 
> Cygwin.])

Try to stick to "w32" and especially avoid "win32" since we don't like
to make it sound like this is a win.

BTW, the next step is probably to support a w32 GUI under GNU+Wine ;-)

> --- a/lisp/international/mule-cmds.el
> +++ b/lisp/international/mule-cmds.el
> @@ -2670,7 +2670,8 @@ See also `locale-charset-language-names', 
> `locale-language-names',
>      ;; On Windows, override locale-coding-system,
>      ;; default-file-name-coding-system, keyboard-coding-system,
>      ;; terminal-coding-system with system codepage.
> -    (when (boundp 'w32-ansi-code-page)
> +    (when (and (eq system-type 'windows-nt)
> +               (boundp 'w32-ansi-code-page))
>        (let ((code-page-coding (intern (format "cp%d" w32-ansi-code-page))))
>       (when (coding-system-p code-page-coding)
>         (unless frame (setq locale-coding-system code-page-coding))

Does w32-ansi-code-page ever make sense under Cygwin?
If it can be useful for Cygwin, is it only useful in combination with
the w32 GUI, or can it also be useful for Cygwin+X11?

Wouldn't it be more correct to change w32fns.c so it does not define
w32-ansi-code-page when built for Cygwin?  Or on the contrary to move
the definition of w32-ansi-code-page so it always gets defined under
Windows, whether we build for Cygwin or not?

> +(unless (eq system-type 'cygwin)
> +  (defcustom w32-allow-system-shell nil
> +    "Disable startup warning when using \"system\" shells."
> +    :type 'boolean
> +    :group 'w32))
> +
> +(unless (eq system-type 'cygwin)
> + (defcustom w32-system-shells '("cmd" "cmd.exe" "command" "command.com"
> +                                "4nt" "4nt.exe" "4dos" "4dos.exe"
> +                                "tcc" "tcc.exe" "ndos" "ndos.exe")
> +   "List of strings recognized as Windows system shells."
> +   :type '(repeat string)
> +   :group 'w32))

You can use a single `unless' around the two defcustoms.

Hopefully someone else can review the core of your code.  I'm familiar
with none of those Windows thingies.  I do like the feature, tho,


reply via email to

[Prev in Thread] Current Thread [Next in Thread]