[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109512: Inline functions to exam

From: Dmitry Antipov
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109512: Inline functions to examine and change buffer overlays.
Date: Wed, 08 Aug 2012 20:26:55 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120713 Thunderbird/14.0

On 08/08/2012 07:45 PM, Stefan Monnier wrote:

Can we pause for a moment?
As I mentioned to you earlier, you should post such patches for review
before installing them.
And explain why you think they're good.
E.g. replacing buffer->overlays_before by "buffer_get_overlays (buffer,
OV_BEFORE)" is far from "obviously good" in my eyes.
If you intend to make those field accesses into something more complex,
then please say so and explain why.  If not, then please stick to
"foo->bar", as agreed for the FGET case.

I think that it's reasonable to have just one chain of overlays per
buffer, much like the markers and intervals chains per buffer text.
And buffer_get_overlays(b, WHAT) is expected to simplify transition
to this possible change.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]