[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/10] move some globals into a thread object

From: Tom Tromey
Subject: Re: [PATCH 01/10] move some globals into a thread object
Date: Mon, 13 Aug 2012 08:19:27 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

>>>>> "Stefan" == Stefan Monnier <address@hidden> writes:

Tom> The #defines mean that this patch also has to rename a few fields
Tom> whose names clash with the defines.

Stefan> I'd rather rename the globals (although I understand it will probably
Stefan> result in a larger patch), because I'd rather limit the impact of those
Stefan> #defines.

Ok, I will do this, but please don't let this block looking at the other
patches.  This particular patch is one of the least interesting ones of
the series.

The big reason not to do this is just that reindenting everything is
tedious.  There are thousands of spots to check for line wrapping :-(
Just thinking about it makes me want to take a different approach instead.

Stefan> If you ever create a local variable (or a struct field) named
Stefan> `current_buffer' somewhere, it might take you a good while to
Stefan> figure out why your code is misbehaving.

FWIW, newish versions of gcc give much better error messages for
problems arising from macro expansion.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]