[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix latent bug in process.c

From: Tom Tromey
Subject: Re: fix latent bug in process.c
Date: Mon, 13 Aug 2012 15:04:26 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)

>>>>> "Andreas" == Andreas Schwab <address@hidden> writes:

Andreas> Tom Tromey <address@hidden> writes:
>> First, we unconditionally set Writeok, even if SELECT_CANT_DO_WRITE_MASK
>> is set.  It seems to me that in one branch we ought to clear Writeok;
>> and only set it in the other.

Andreas> It doesn't matter, since if SELECT_CANT_DO_WRITE_MASK is defined
Andreas> write_mask will always be empty anyway (w32 does not support dbus).

I suppose so, but I think it is more future-proof this way.

The second part is really the interesting one though.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]