[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: bug#12022: [PATCH] Unable to use anonymous functions for Key Transla
Re: bug#12022: [PATCH] Unable to use anonymous functions for Key Translations
Tue, 21 Aug 2012 13:40:17 -0400
Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)
> What I'm really doing involves the need for a closure, so I proceeded to
> enable lexical binding. This causes the test case to fail again. I looked
> into it and found that DEFUN("functionp", ...) checks EQ (car, Qclosure)
> but FUNCTIONP does not.
Oops, sounds like a bug.
> We could add the same check to FUNCTIONP, but I'm
> wondering if one of these functions should leverage the other?
Yes. The bulk of Ffunctionp should probably be moved to lisp.h into
a "functionp" inlinable function, then make FUNCTIONP an alias
for functionp and make Ffunctionp use functionp.