Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109864: Fix minor problems found by static checking.

[Stefan Monnier]

>> --- a/src/doc.c      2012-09-02 16:56:31 +0000
>> +++ b/src/doc.c      2012-09-03 09:22:43 +0000
>> @@ -848,9 +848,10 @@
>> struct buffer *oldbuf;
>> ptrdiff_t start_idx;
>> /* This is for computing the SHADOWS arg for describe_map_tree.  */
>> -      Lisp_Object active_maps = Fcurrent_active_maps (Qnil, Qnil);
>> +      Lisp_Object active_maps;
>> Lisp_Object earlier_maps;
>> 
>> +      active_maps = Fcurrent_active_maps (Qnil, Qnil);
>> changed = 1;
>> strp += 2;           /* skip \{ or \< */
>> start = strp;

> What problems did static checking find in this (and other similar)
> fragment?

Yes, I curious, especially since the resulting code is less elegant.


        Stefan