emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from


From: martin rudalics
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r109890: Do not mark objects from deleted buffers, windows and frames.
Date: Thu, 06 Sep 2012 09:28:52 +0200

>> E.g. you might still be able to get (window|frame)-parameters of
>> a deleted (window|frame).
>
> I'm pretty sure that this is invalid and should be fixed.

Yes.  It won't be allowed any more for windows.

> Since we can't implement this just now, I'm reverting window marking;
> but I think that I'll spent more time on this :-).

... and please tell the people from bug 12251 about it ;-)

> Hm. For example, killed buffers may sit in all_buffers for a while, and
> still
> have from tens to thousands reachable objects per buffer (although I didn't
> check whether these objects are reachable only from this dead buffer).

Could you elaborate?

> I agree about the safety, but: 1) this is slower; 2) IMHO this is
> conceptually
> wrong and 3) it still has it's own traps (for example, if we set all
> Lisp_Objects
> slot of the deleted window to Qnil, set-window-configuration will not
> work since
> it assumes that the restored window has valid marker objects at W->start
> and W->pointm).

Marker objects belong to the buffer.  The start and pointm fields are
regenerated from the saved window structure.  Please elaborate.

martin



reply via email to

[Prev in Thread] Current Thread [Next in Thread]