Re: [PATCH] Fix bug #11580

[Tassilo Horn]

Sergio Durigan Junior <address@hidden> writes:

Hi Sergio,

> WDYT of the new patch below?

--8<---------------cut here---------------start------------->8---
=== modified file 'lisp/net/eudcb-bbdb.el'
--- lisp/net/eudcb-bbdb.el      2012-01-19 07:21:25 +0000
+++ lisp/net/eudcb-bbdb.el      2012-09-26 18:14:52 +0000
@@ -166,7 +166,7 @@
                                  (symbol-name attr)))
                         'record))))
        (t
-       (setq val "Unknown BBDB attribute")))
+       (error "Unknown BBDB attribute")))
       (if val
        (cond
         ((memq attr '(phones addresses))
@@ -176,6 +176,8 @@
          (setq eudc-rec (cons (cons attr (car val)) eudc-rec)))
         ((> (length val) 0)
          (setq eudc-rec (cons (cons attr val) eudc-rec)))
+        ((and (not (listp val)) (string= val ""))
+         nil) ; Do nothing
         (t
          (error "Unexpected attribute value")))))
     (nreverse eudc-rec)))
--8<---------------cut here---------------end--------------->8---

In the second hunk, the (not (listp val)) is not needed.  If val was a
list, it would have entered one of the two preceeding clauses, but
that's just nitpicking.

Anyway, only Roland knows exactly what's the right fix for the issue, so
he should decide what to do.

Bye,
Tassilo