[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CEDET non-regression bug fixes

From: David Engster
Subject: Re: CEDET non-regression bug fixes
Date: Wed, 14 Nov 2012 19:56:31 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.2.50 (gnu/linux)

Stefan Monnier writes:
>> === modified file 'lisp/cedet/semantic/complete.el'
>> --- lisp/cedet/semantic/complete.el  2012-10-12 19:56:34 +0000
>> +++ lisp/cedet/semantic/complete.el  2012-11-04 21:06:33 +0000
>> @@ -1340,7 +1343,10 @@
>>  (defmethod semantic-displayor-scroll-request ((obj 
>> semantic-displayor-abstract))
>>    "A request to for the displayor to scroll the completion list (if 
>> needed)."
>> -  (scroll-other-window))
>> +  (with-selected-window (get-buffer-window "*Completions*")
>> +    (if (posn-at-point (point-max))
>> +    (goto-char (point-min))
>> +      (scroll-up))))
> This will signal an error when *Completions* is not displayed anywhere.

At this stage, there must be a *Completions* buffer, otherwise it's an
error anyway. But regarding the freeze, I will wrap something around
that making sure it exists.

>> -               (buff (get-file-buffer file))
>> +               (buff (find-buffer-visiting file))
> We need to do something to avoid those problems.  AFAIK there's no
> reason to ever prefer get-file-buffer over find-buffer-visiting, so
> maybe we should simply get rid of get-file-buffer and make it an alias
> of find-buffer-visiting.

Oh, you have my vote for that. But I have a hunch you won't put this
change into the emacs-24 branch, so I read this comment as "Fine, please
commit". ;-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]