[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet,

From: Stefan Monnier
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111086: gmm-utils.el (gmm-flet, gmm-labels): New macros.
Date: Tue, 04 Dec 2012 23:19:05 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> Defadvice?  Uhm, that defadvice code exists in an official source
> code is very ugly, I feel. :<

The problem with defadvice is that it overrides functions.  The letf
cases we're talking about also override functions, so they're just as
nasty as uses of defadvice.  Worse, they don't even announce themselves
in the docstring and they often remove themselves before you get
a chance to see that some overriding is going on.

So, yes, I much prefer defadvice.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]