[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Added inotify support.

From: Eli Zaretskii
Subject: Re: [PATCH] Added inotify support.
Date: Mon, 10 Dec 2012 13:52:48 +0200

> From: Rüdiger Sonderfeld <address@hidden>
> Date: Mon, 01 Oct 2012 16:09:55 +0200
> Cc: Leo <address@hidden>, address@hidden
> On Monday 01 October 2012 00:38:09 Stefan Monnier wrote:
> > If there's a good chance this won't work without breaking compatibility,
> > maybe a better option is to provide a low-level API that maps very
> > closely to inotify and then an Elisp layer on top which abstracts away
> > differences between different systems.  In that case we can install the
> > inotify support right away while we're still experimenting with the
> > higher-level abstraction.
> That's probably the best approach here.  I changed the patch to provide a low
> level inotify interface.  However I did not provide an inotify_init(2) like 
> function and instead initialization and closing of the inotify handle is done
> internally.  I don't think that this should be exposed to elisp even in the 
> low level interface.
> > But if they're unlikely to be important in practice, then
> > I guess the current solution might be acceptable.
> I think we are safe.  I added that `equal' should be used to compare cookies. 
> So we can easily change it without breaking the API.

Committed (with necessary fixes and additions, like ChangeLog entries
and NEWS) as trunk revision 111171.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]