[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC] using "optimizaiton 1"

From: Dmitry Antipov
Subject: Re: [RFC] using "optimizaiton 1"
Date: Fri, 14 Dec 2012 20:47:28 +0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0

On 12/14/2012 06:15 PM, Eli Zaretskii wrote:

Date: Fri, 14 Dec 2012 18:10:10 +0400
From: Dmitry Antipov <address@hidden>
CC: Eli Zaretskii <address@hidden>

Surprisingly, "optimizaiton 1" from redisplay_internal can
handle the case if the region is highlighted, too. Comments?

Sorry, I don't understand: handle which case?

IOW, I suspect that this code:

 13248    /* If showing the region, and mark has changed, we must redisplay
 13249       the whole window.  The assignment to this_line_start_pos prevents
 13250       the optimization directly below this if-statement.  */
 13251    if (((!NILP (Vtransient_mark_mode)
 13252          && !NILP (BVAR (XBUFFER (w->buffer), mark_active)))
 13253         != !NILP (w->region_showing))
 13254        || (!NILP (w->region_showing)
 13255            && !EQ (w->region_showing,
 13256                    Fmarker_position (BVAR (XBUFFER (w->buffer), mark)))))
 13257      CHARPOS (this_line_start_pos) = 0;

is obsolete (heh, it's there since 1993). If showing the region, and both PT and
mark are on the same line, we should go through the monster if-statement below 

 13293            /* We have to handle the case of continuation around a
 13294               wide-column character (see the comment in indent.c around
 13295               line 1340).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]