[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Redundant (harmful) duplication of run-hooks in define-globalized-mi

From: Stefan Monnier
Subject: Re: Redundant (harmful) duplication of run-hooks in define-globalized-minor-mode [patch-2]
Date: Fri, 01 Feb 2013 18:16:37 -0500
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> Is it OK to commit this change to emacs-24 now, and close bug#11152?

No, I think this is good for trunk but not for emacs-24.
I think that for emacs-24 we need a less invasive change.

For that we should probably go back and try and figure out why the hook
is run both times.  As mentioned, the code tries to avoid running it
twice by checking the value of `major-mode', so it appears that in the
problem case, `major-mode' changes between the two hooks.  Can you try
and figure out if that's indeed the case and why?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]