[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Long lines and bidi

From: Eli Zaretskii
Subject: Re: Long lines and bidi
Date: Sat, 09 Feb 2013 11:33:21 +0200

> Date: Sat, 09 Feb 2013 01:05:01 -0800
> From: Paul Eggert <address@hidden>
> Cc: address@hidden, address@hidden
> > At the very least, the name of the function should be
> > changed to reflect the change.
> Sure, what name do you suggest?  scan_newline is already taken.
> Perhaps scan_buffer_newline?

I'd use find_newline, since 2 out of 3 of its callers are
find_next_newline_no_quit and find_before_next_newline.

> This area is a bit messed up, unfortunately -- scan_newline has
> comments saying that it looks for carriage return (!) but
> it does not in fact do that.

People tend to forget updating the commentary when they change code.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]