[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: cl-defstruct-based package.el, now with ert tests!

From: Ted Zlatanov
Subject: Re: cl-defstruct-based package.el, now with ert tests!
Date: Tue, 12 Mar 2013 14:13:47 -0400
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

On Tue, 12 Mar 2013 16:03:05 +0400 Dmitry Gutov <address@hidden> wrote: 

DG> Tom Tromey <address@hidden> writes:
Daniel> The changes touch most of the code, but the overall structure of the
Daniel> code has not changed significantly. Some parts of the code which were
Daniel> questionable in the first place (such as using `tar-mode' to extract tar
Daniel> archives) have been replaced with simpler alternatives. In the case of
Daniel> tar, the file is simply downloaded to a temporary directory and
Daniel> extracted using "tar xaf foo-1.2.3.tar".
>> This sounds worse to me, since it means that now package installation
>> has an external dependency.  Previously this was not the case --
>> intentionally.

DG> Indeed, if that means that it won't work on vanilla Windows
DG> installations, then this decision should be reversed.

Agreed, maybe Daniel can explain why using `tar-mode' was questionable.  

DG> The change looks good otherwise, I especially like the presence of tests.

Same here.  I like the standardization of the internals.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]