[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Any exceptions for the 15-line rule?

From: Glenn Morris
Subject: Re: Any exceptions for the 15-line rule?
Date: Wed, 01 May 2013 14:06:13 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Dmitry Gutov wrote:

> Thank you. I don't think I've seen a good definition of "tiny change"
> anywhere, and there's no s/foo/bar in either of these patches, but if
> you suggest to use my own judgment, that's fine by me.

s/foo/bar was just an example.

You need to look at the change and ask, "conceptually, how big is this"?
Deleting says 15 lines of common code from two places and turning it
into a separate function that those two places call only "counts" as a
few lines IMO (the function definition part, the function body is the
same code as before, just moved around).

If in doubt, err on the side of getting an assignment. It also makes
life easier when the same person contributes more in future.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]