[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix for bug 10994 breaks ido customizations in major way

From: Vitalie Spinu
Subject: Re: fix for bug 10994 breaks ido customizations in major way
Date: Tue, 07 May 2013 00:49:24 +0200
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux)

 >> Le Wang <address@hidden>
 >> on Sat, 4 May 2013 15:00:24 +0800 wrote:

 > On Sat, May 4, 2013 at 4:33 AM, Leo Liu <address@hidden> wrote:
 >> On 2013-05-03 20:49 +0800, Le Wang wrote:
 >> > There are a few ido customizations floating around that propertizes text.
 >> >  This will break all of them.  I don't think this fix is acceptable.

What do you mean by "break"? 

When propertied strings are used, they are used for a reason - to carry
additional information. 

There are plenty of applications that might need same strings but with
different meaning. For example ido for tag or imenu navigation, there
might be several locations where a symbol is used/defined. Help topics
might have same name but be in different files/packages. Same file-names
in different directories. Same index entry but different locations, etc.

 >> That I wouldn't know. I only know what is in emacs and that the fix has
 >> been in use for a while.  Feel free to propose a different fix

 > Sure, I've attached a patch that deletes duplicates.


(let ((t1 (propertize "aaa" 'aaa 12))
      (t2 (propertize "aaa" 'aaa 11)))
  (ido-completing-read "?: " (list t1 t2 "sfd")))

works as expected. And the above patch breaks that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]