[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Using glib's g_file_monitor_file and g_file_monitor_directory

From: Michael Albinus
Subject: Re: Using glib's g_file_monitor_file and g_file_monitor_directory
Date: Wed, 29 May 2013 15:30:57 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> I'd rather not special-case w32 unless really necessary.  (The whole
> point of using the Posix configury was to remove as much w32-specific
> stuff as possible from the build process.)  So yes, let's by all means
> support "no" for w32, although I'm not sure who'd want that.  And
> please also include mingw32 in the same test harness where you test
> for gfilenotify and inotify, i.e. test for a header (windows.h will
> do), not the value of $opsys.


> Btw, glib is available for Windows as well, and AFAICT its
> gfilemonitor should work (it actually uses the same APIs as
> w32notify.c does).  So "gfile" should not be precluded from the w32
> build.


> See above: I'd prefer this to be a real test, based on windows.h
> presence.  And if the user selected "gfile", let them have it, do not
> override with w32notify.o.

Also done.

>> +#if defined (HAVE_GFILENOTIFY) || defined (HAVE_INOTIFY) || defined 
> It sounds like a single symbol HAVE_FILE_NOTIFY, defined somewhere as
> the OR of these 3, should make the sources more readable.


I will wait another couple of days (let's say until Sunday evening), if
there's no objection I will commit. I cannot test the MS Windows case;
here I trust on you.

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]