emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: code review request for saveplace with dired buffer


From: Glenn Morris
Subject: Re: code review request for saveplace with dired buffer
Date: Mon, 10 Jun 2013 12:35:27 -0400
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Ivan Kanis wrote:

> +2013-06-99 Ivan Kanis <address@hidden>
> +     Add support for dired in saveplace.
> +     * dired.el (dired-initial-position-hook): New variable.

Add blank line before "Add support".

> + (save-place-position-dired-cursor): Move cursor in dired from previous 
> position.

You can simply say "New function". "New function to move..." if you prefer.
As has been pointed out, "point" is better than "cursor", in function
names as well as doc.

> +(defcustom dired-initial-position-hook nil
> +  "This hook is used to position the cursor position."
> +  :group 'dired
> +  :type 'hook)

Add :version "24.4".

I'd find a comment in the doc "Run by the function `dired-initial-position'."
helpful. And likewise in the doc of `dired-initial-position': "Runs the
hook `dired-initial-position-hook'."



reply via email to

[Prev in Thread] Current Thread [Next in Thread]