[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Small improvements to ruby-mode

From: Dmitry Gutov
Subject: Re: Small improvements to ruby-mode
Date: Fri, 05 Jul 2013 14:30:04 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7

On 05.07.2013 13:56, Bozhidar Batsov wrote:
The patch looks good with one minor problem - you've included `autoload`
twice (the second time it's in Module's methods).

Thanks for the catch.

While on the subject of small improvements here's a few more ideas:

* replace cl with cl-lib (that should be done eventually I guess)

Yeah, I guess.

* update the front-matter comment since it's pretty out-of-date

What exactly do you propose to change? If the file is installed manually, and if it's not autoloaded, the user has to add some auto-mode-alist entries.

* run a whitespace cleanup on the code :-)

Untabify, you mean? It's the core's policy not to touch tabs vs. spaces until you meaningfully modify nearby code.

* highlight yard and rdoc special syntax in comments - like Emacs Lisp does

Have you looked at https://github.com/pd/yard-mode.el/ ?

The only problem with it I can see is, it sets eldoc-documentation-function, so it can't be used outside of comments. I guess we'll eventually need eldoc-documentation-functions hook, like we have for completions.

* make use of `font-lock-negation-char-face` for !

Uh, okay. Is it different from the default face, in any themes?

* maybe make of use of new `font-log-regexp-grouping-construct-face` as well

I think highlighting backslash sequences is more important, and the two approaches are somewhat incompatible. See:


P.S. Please try to keep emacs-devel in Cc.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]