[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Blinking cursor on w32

From: Eli Zaretskii
Subject: Blinking cursor on w32
Date: Sat, 27 Jul 2013 14:57:13 +0300

It looks like the port to w32 of the latest changes related to
blinking cursor is incomplete.  If I put breakpoints on
handle-focus-in/out, and do the mouse gestures that switch focus to
and from the Emacs frame, I see handle-focus-in being called, but
handle-focus-out never is.  (On my system, just moving the mouse
pointer off the Emacs frames switches focus out of the frame; on other
systems, you'd actually need to click on some other frame.  But I
don't think this matters.)

The result is that setting blink-cursor-blinks to zero does not work
as intended: the timer continues to run even when none of Emacs frames
have focus.

The changes below fix this for me; OK to commit?

=== modified file 'src/w32term.c'
--- src/w32term.c       2013-07-26 09:59:59 +0000
+++ src/w32term.c       2013-07-27 11:48:35 +0000
@@ -4923,16 +4923,11 @@ w32_read_socket (struct terminal *termin
        case WM_KILLFOCUS:
+         w32_detect_focus_change (dpyinfo, &msg, &inev);
          f = x_top_window_to_frame (dpyinfo, msg.msg.hwnd);
           if (f)
-              if (f == dpyinfo->w32_focus_event_frame)
-                dpyinfo->w32_focus_event_frame = 0;
-              if (f == dpyinfo->w32_focus_frame)
-                x_new_focus_frame (dpyinfo, 0);
               if (f == hlinfo->mouse_face_mouse_frame)
                   /* If we move outside the frame, then we're

reply via email to

[Prev in Thread] Current Thread [Next in Thread]