[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Broken bootstrap in r113623

From: Eli Zaretskii
Subject: Re: Broken bootstrap in r113623
Date: Wed, 31 Jul 2013 19:28:26 +0300

> Date: Wed, 31 Jul 2013 18:45:43 +0400
> From: Dmitry Antipov <address@hidden>
> Cc: Xue Fuqiao <address@hidden>
> ...
> make[3]: Entering directory 
> `/home/dima/work/stuff/emacs/trunk/build-debug/doc/emacs'
> /bin/makeinfo --force --enable-encoding -I 
> /home/dima/work/stuff/emacs/trunk/doc/emacs --no-split -o 
> /home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info 
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi
> /home/dima/work/stuff/emacs/trunk/doc/emacs/emacs.texi:547: Cross reference 
> to nonexistent node `Disabling Multibyte' (perhaps incorrect sectioning?).
> make[3]: *** 
> [/home/dima/work/stuff/emacs/trunk/doc/emacs/../../info/emacs.info] Error 1
> ...


Xue, please in the future always run "make info" whenever you make any
changes in the manual.  Otherwise, the risk of gratuitously breaking
the build is quite high.

Please also make a point of mentioning _all_ of your changes in
ChangeLog entries (in this case, the removal of the "Disabling
Multibyte" node was never mentioned).

Finally, please use meaningful commit messages.  Something like "Doc
fix" does not have any meaningful information, and thus is useless.
We use "Doc fix" when making changes to doc strings of Lisp functions,
but then we always state the name of the function whose doc string was
fixed, and in any case calling 5 non-trivial changes "Doc fix" is not
a good idea.  Think about the plight of someone who wants to get a
quick overview of a series of changes by doing "bzr log -l10 --line".

reply via email to

[Prev in Thread] Current Thread [Next in Thread]