[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Simple lisp-tests.el and commit privs

From: Barry OReilly
Subject: Re: Simple lisp-tests.el and commit privs
Date: Wed, 14 Aug 2013 13:49:47 -0400

> Currently, the way I like to handle indentation tests is by adding
> files in test/indent/ where the file simply contains a pre-indented
> content, and the Makefile lets you "reindent, then run diff to see
> if something changed".

I couldn't tell, since test/automated has ERT indentation tests for
Python, Ruby, and Fortran. I didn't find that your preferred
diff based indentation tests are run as a part of the automated 'make
check'. I did find several fail when run manually.

Automating the indentation tests would make them more valuable. If we
were to automate the diff based indentation tests, I think we ought to
wrap it with ERT so as it is executed and reported in the same manner
as the other automated tests. Yet if we're going to use ERT, then the
approach taken by the python-tests.el, ruby-mode-tests.el, f90.el
isn't less simple.

Finally, why foreclose tests for indenting non indented buffer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]