[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tram

From: Michael Albinus
Subject: Re: trunk r114123: * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices):
Date: Fri, 06 Sep 2013 11:41:30 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Stefan Monnier <address@hidden> writes:

Hi Stefan,

> message:
>   * lisp/net/tramp-gvfs.el (tramp-gvfs-mount-spec, tramp-synce-list-devices): 
>   * lisp/net/tramp-smb.el (tramp-smb-get-file-entries):
>   * lisp/net/tramp-sh.el (tramp-sh-handle-insert-directory)
>   (tramp-compute-multi-hops): Fix misuses of `add-to-list'.

With this change (replacing `add-to-list' by `pushnew') I get compiler
warnings like this:

--8<---------------cut here---------------start------------->8---
emacs24 --no-site-file -batch -l bytecomp \
        --eval "(add-to-list 'load-path default-directory)" \
        -f batch-byte-compile tramp-sh.el

In tramp-compute-multi-hops:
tramp-sh.el:4277:31:Warning: function `adjoin' from cl package called at
emacs24 --no-site-file -batch -l bytecomp \
        --eval "(add-to-list 'load-path default-directory)" \
        -f batch-byte-compile tramp-gvfs.el

In tramp-synce-list-devices:
tramp-gvfs.el:1718:38:Warning: function `adjoin' from cl package called at
--8<---------------cut here---------------end--------------->8---

This does not happen for the trunk version, but for older Emacsen (like
24.2, used in this example).

Is your change worth the trouble? And if yes, how to handle those warnings?

Best regards, Michael.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]