[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Set operations on bool-vectors
From: |
Stefan Monnier |
Subject: |
Re: Set operations on bool-vectors |
Date: |
Fri, 20 Sep 2013 21:57:04 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) |
> I've implemented built-in set operations on bool vectors.
Thanks. Looks good.
> According to my benchmarks, these operations are about 1,000 times
> faster than the compiled elisp equivalents.
I'd expect no less.
> === modified file 'src/alloc.c'
> --- src/alloc.c 2013-09-04 22:34:04 +0000
> +++ src/alloc.c 2013-09-19 22:24:27 +0000
> @@ -2003,6 +2003,29 @@
> return val;
> }
Could you describe the intention of the changes in alloc.c (basically,
provide ChangeLog entries)?
> + doc: /* Compute A = B ^ C, bitwise exclusive or.
Why not make it C = A ^ B and then make C optional?
Same for other similar functions: make the destination argument optional.
Stefan