[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Generating byteswap.h on Windows

From: Eli Zaretskii
Subject: Re: Generating byteswap.h on Windows
Date: Fri, 04 Oct 2013 17:09:31 +0300

> Date: Fri, 04 Oct 2013 14:47:38 +0200
> From: martin rudalics <address@hidden>
> CC: address@hidden
>  > Why leave it to me?
> Because as a rule I only install changes I understand and I don't
> understand makefiles.

If the build was broken, and your change fixes it, the fix is worth
installing, so that others could build successfully.  We can always
improve the fix later, if needed.

IOW, installing a fix can never make things worse than they are when
the build is broken.

> Moreover I now have byteswap.h in my lib directory and according to
> bzr status I would commit that too.  So I'd also have to learn how
> to avoid that.

You can "bzr commit" specific files.  But the general rule for this is
add the file to .bzrignore.

>  > Please install whatever changes you find that fix
>  > any breakage.
> If you can't commit I can do it but at least give me some sort of
> approval first that Paul's patch is correct.

You will always have my approval for committing something that fixes a
broken build.  I just don't want that it will always depend on me,
because I'm sometimes busy or unavailable.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]