[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.

From: Eli Zaretskii
Subject: Re: [Emacs-diffs] trunk r114593: * lisp.h (eassert): Don't use 'assume'.
Date: Fri, 11 Oct 2013 10:00:15 +0300

> Date: Thu, 10 Oct 2013 23:36:24 -0700
> From: Paul Eggert <address@hidden>
> Daniel Colascione wrote:
> > By merging eassert_and_assume with eassert, then removing the assume from 
> > eassert, you've essentially removed calls to assume and pessimized the code.
> OK, in trunk bzr 114622 I restored eassert_and_assume
> (under the shorter name 'eassume'), but can you measure
> how much performance you're gaining with this change?
> The eassume macro is tricky to use (as it sometimes makes
> performance worse) so I'd rather omit it if any
> performance gains are insignificant.

I'm also curious as to why this is needed.  Again, 'assume' is an
optimization device, and 'eassert' is not normally compiled in
optimized builds.  What are the use cases for this?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]