emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: build fails with new MinGW wchar.h


From: Claudio Bley
Subject: Re: build fails with new MinGW wchar.h
Date: Thu, 21 Nov 2013 08:36:23 +0100
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Goj┼Ź) APEL/10.8 Emacs/24.3.50 (i686-pc-mingw32) MULE/6.0 (HANACHIRUSATO)

At Wed, 20 Nov 2013 20:15:41 +0200,
Eli Zaretskii wrote:
> 
> > diff --git a/nt/inc/sys/stat.h b/nt/inc/sys/stat.h
> > index f1d8341..88352b1 100644
> > --- a/nt/inc/sys/stat.h
> > +++ b/nt/inc/sys/stat.h
> > @@ -23,6 +23,8 @@ along with GNU Emacs.  If not, see 
> > <http://www.gnu.org/licenses/>.  */
> > 
> >  #ifdef __MINGW32__
> >  # include <_mingw.h>
> > +# define _STAT_DEFINED
> 
> Why did you need this part?  nt/inc/sys/stat.h already defines
> _STAT_DEFINED, why do we need a second definition.

I just did not realize that it already has that defined.

> > +# define _WSTAT_DEFINED
> 
> We cannot define this symbol without also declaring the structures
> guarded by it in the MinGW headers.  We should add them, and then
> define _WSTAT_DEFINED.

Why? Since those declarations are not used anyway, what's the point in
defining them in the first place?

Furthermore, this define actually does not guard declarations of any
structures, but only guards declarations of the functions:

_wstat
_wstat32
_wstat64
_wstat32i64
_wstat64i32

IMO, since none of those functions is used in Emacs' code base, we're
already set.

/ Claudio



reply via email to

[Prev in Thread] Current Thread [Next in Thread]