[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-m

From: Glenn Morris
Subject: Re: trunk r115158: * lisp/progmodes/ruby-mode.el (ruby-custom-encoding-magic-comment-template):
Date: Fri, 22 Nov 2013 21:37:12 -0500
User-agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)

Thanks for adding a test/ChangeLog entry.
Do please list the names of the tests in the entry.
ChangeLog entries should name every function, variable that they touch.
I notice this did not happen eg in
which changed an option, added several new functions, and modified
another, but only mentioned the last in the ChangeLog.

does not list the two new options as entities in their own right.

Please could you review all your past changes with an eye to that,
and improve the ChangeLogs where necessary?

Also, maybe you want to add a NEWS entry about those new options.
This need be nothing more than:

  ** New Ruby mode options: foo, bar.

in the "Changes in Specialized Modes and Packages in Emacs 24.4" section.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]